cow-venue: type the retry classifier boundary with OrderbookApiErrorType - #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The retry classifier boundary becomes typed.
classifyandis_already_submittednow takecowprotocol::OrderbookApiErrorTypeinstead of&str, and the adapter passesapi.error_kind()instead of&api.error_type. TheUnknown(_)variant is handled explicitly at the call site (an unlisted wireerrorTypeis by definition permanent, so it drops).Why
OrderbookApiErrorTypealready exists (with anUnknown(String)fallback) and the crate's parity test already trusts it, but the hot path stayed stringly, so a call site could pass an arbitrary or misspelt&strwith no compile-time signal. The generated table may stay string-backed internally (matched viaas_str()), but nothing untyped now crosses the classifier boundary.Testing
Full battery on the pinned 1.94 toolchain, all green:
nix develop --command just ci(fmt, clippy-D warnings, doc, module wasms,cargo test --workspace --all-features)nix develop --command just build-cow-venuenix develop --command just check-venue-agnosticnix develop --command just check-cow-orderbook-onlyAI Assistance
Implemented with Claude Code.
Closes #496